[bug] [gui] Fix a bug of drawing mesh instacing that cpu/cuda objects have an offset when copying to vulkan object #6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b443eb0.
…ble objects) directly
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Morcki
requested review from
ailzhang,
jim19930609,
PENGUINLIONG and
bobcao3
bobcao3
reviewed
Sep 13, 2022
bobcao3
reviewed
Sep 13, 2022
|
/rebase |
|
Rebase failed, please resolve the conflicts manually. |
May I merge this directly and solve the conflicts? It seems that rebase is a bit troublesome. |
|
@Morcki you can resolve merge conflict locally and the force push into this branch. |
… backends when copying to vulkan backend [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Cpu backend is with LLVM and add annotation for memcpy_cpu_to_vulkan [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci fix a bug when transforms is None, instance count must be 1 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci fix a small bug change ssbo to device-local memory [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
Morcki
force-pushed
the
taichi_fix_bug
branch
from
8bea7bb to
8d5fdca
Compare
jim19930609
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only happend on Windows.