OpenGL external array access (stage 2.1.2) #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sleepy now Zzz... enjoy code reviewing :) |
|
Hello? |
archibate
changed the title
|
I rebased this PR to #594. Please merge that before merge this. |
|
Should we merge into taichi-dev:opengl instead of taichi-dev:master for not rushing the v6.0 release? |
fix fix again
Conflicts: taichi/codegen/codegen_opengl.cpp taichi/platform/opengl/opengl_kernel.cpp taichi/platform/opengl/opengl_kernel.h
We have plenty of time before we release v0.6. Only merging into taichi-dev:opengl might lead to other issues when merging opengl into master. Let's directly make these parts of the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue id = #492