Support break in non-parallel for statements by translate range-for into while #578

[archibate]

Related issue id = #578

[archibate]

Why transform my BinaryOpStmt(cmp_lt) into const [0].

[archibate]

Why transform my BinaryOpStmt(cmp_lt) into const [0].

May because that cond_stmt not inserted into stmts.

[archibate]

Too hard, can't do this at all.

[yuanming-hu]

Too hard, can't do this at all.

What exactly stopped you? :-)

[archibate]

Too hard, can't do this at all.

What exactly stopped you? :-)

Don't have a clear image of how block (and thus insert_before_me) works.

[archibate]

Can I just translate it into FrontendWhileStmt instead of WhileStmt? (in somewhere before lower_ast)

[yuanming-hu]

Can I just translate it into FrontendWhileStmt instead of WhileStmt? (in somewhere before lower_ast)

Actually, after taking a look at your current implementation, I think it's very very close! We should probably stick to the current one.

[archibate]

Can I just translate it into FrontendWhileStmt instead of WhileStmt? (in somewhere before lower_ast)

Actually, after taking a look at your current implementation, I think it's very very close! We should probably stick to the current one.

Close? Don't understand why it make my BinaryOpStmt becomes const [0].. May be closer if this mystery could reason..

[archibate]

Seems whilestmt used a diff way from forstmt to insert: insert-before-me and flattened. Go bed now.

[yuanming-hu]

Thanks. I'll take a look after a meeting.

[yuanming-hu]

Is there a way to reproduce your issue? Which test case should I run? I think your implementation looks promising. Just need to figure out what's wrong in detail.

[yuanming-hu]

Added a simple test and rebase your commits after code reformatting to avoid future merge conflicts. Please update locally.

[archibate]

You've made TAB=4??! Great to know the process of style enforcing but I would suggest to use TAB="\t" so that user can make themselves happy with editor settings..

[archibate]

Done! Run ninja -C build && ti test for_break -v --arch opengl to reproduce.

[archibate]

Seems whilestmt used a diff way from forstmt to insert: insert-before-me and flattened. Go bed now.

Exactly this caused problem, fixed using flattened2.

[archibate]

Next: how to detect if is_good_range_for.

[archibate]

Can we disable print_ir for snode accessors?

[yuanming-hu]

Can we disable print_ir for snode accessors?

I think that's already disabled by default?

[archibate]

I think that's already disabled by default?

No, still print something like 2d_ten_arr.

[archibate]

Hello? Have time tonight.

[archibate]

Fixed one, stupid error.

[archibate]

If begin < end, we enumerate [begin, end).
If end > begin, we enumerate [end, begin) or (end, begin]?

[archibate]

Do we have IncStmt for something like x++? Or at least AugAssignStmt for x += 1?

[archibate]

Can we merge this now?

[archibate]

unordered_set?? Wasn't set itself already means unordered? Sorry, I'm not a C++ expert..

[yuanming-hu]

unordered_set?? Wasn't set itself already means unordered? Sorry, I'm not a C++ expert..

Well, set is actually ordered: https://en.cppreference.com/w/cpp/container/set std::set is an associative container that contains a sorted set of unique objects of type Key.

Can we merge this now?

Will do it once CI passes. Just now rebased on master to avoid merge conflicts. This will be shipped with v0.5.9 tonight/tomorrow.