Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Indexing for new local matrix implementation #5783

Merged
merged 108 commits into from
Sep 14, 2022

Conversation

AD1024
Copy link
Contributor

@AD1024 AD1024 commented Aug 15, 2022

Related issue = #5478
A part of PR #5551

@netlify
Copy link

netlify bot commented Aug 15, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 19ec61f
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6320e524e2b25b00090fc69f
😎 Deploy Preview https://deploy-preview-5783--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@AD1024 AD1024 marked this pull request as ready for review August 15, 2022 23:31
tests/python/test_matrix.py Outdated Show resolved Hide resolved
tests/python/test_matrix.py Outdated Show resolved Hide resolved
tests/python/test_matrix.py Outdated Show resolved Hide resolved
python/taichi/_funcs.py Show resolved Hide resolved
python/taichi/_kernels.py Show resolved Hide resolved
taichi/ir/frontend_ir.cpp Outdated Show resolved Hide resolved
taichi/ir/frontend_ir.cpp Outdated Show resolved Hide resolved
taichi/codegen/llvm/codegen_llvm.cpp Outdated Show resolved Hide resolved
@AD1024 AD1024 requested a review from strongoier September 8, 2022 22:31
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

python/taichi/lang/impl.py Outdated Show resolved Hide resolved
taichi/ir/frontend_ir.cpp Outdated Show resolved Hide resolved
taichi/ir/frontend_ir.cpp Show resolved Hide resolved
@AD1024 AD1024 merged commit 6389f26 into taichi-dev:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Run complete set of CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants