[Lang] Enable definition of local matrices/vectors #5782

AD1024 · 2022-08-15T17:49:26Z

Related issue = #5478
A part of PR #5551

netlify · 2022-08-15T17:49:31Z

✅ Deploy Preview for docsite-preview ready!

Name	Link
🔨 Latest commit	`5ed0e93`
🔍 Latest deploy log	https://app.netlify.com/sites/docsite-preview/deploys/630721861c5b680009e80a5b
😎 Deploy Preview	https://deploy-preview-5782--docsite-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

for more information, see https://pre-commit.ci

taichi/transforms/type_check.cpp

taichi/transforms/alg_simp.cpp

taichi/runtime/llvm/llvm_context.cpp

taichi/python/export_lang.cpp

taichi/ir/statements.h

taichi/ir/frontend_ir.h

taichi/ir/control_flow_graph.cpp

taichi/analysis/data_source_analysis.cpp

taichi/codegen/llvm/codegen_llvm.cpp

jim19930609 · 2022-08-17T03:55:39Z

Nice work! Just some comments wrt implementation details~

for more information, see https://pre-commit.ci

jim19930609

Thanks!

strongoier

BTW have you tried to run tests locally to see if things work well with dynamic_index=True (the tests are not enabled in CI)?

python/taichi/lang/ast/ast_transformer.py

python/taichi/lang/matrix.py

python/taichi/lang/impl.py

python/taichi/lang/matrix.py

taichi/ir/frontend_ir.h

taichi/transforms/type_check.cpp

taichi/codegen/llvm/codegen_llvm.cpp

Co-authored-by: Yi Xu <[email protected]>

for more information, see https://pre-commit.ci

AD1024 · 2022-08-23T23:27:42Z

BTW have you tried to run tests locally to see if things work well with dynamic_index=True (the tests are not enabled in CI)?

Will try. I don't think this would be an issue.

taichi/transforms/alg_simp.cpp

taichi/ir/type_utils.cpp

taichi/codegen/llvm/codegen_llvm.cpp

This reverts commit b9fd3a9.

for more information, see https://pre-commit.ci

taichi/transforms/alg_simp.cpp

taichi/ir/frontend_ir.cpp

taichi/analysis/data_source_analysis.cpp

…ostpone var alloca to ast transformer

taichi/transforms/alg_simp.cpp

python/taichi/lang/impl.py

taichi/ir/frontend_ir.cpp

strongoier

LGTM!

taichi/python/export_lang.cpp

python/taichi/lang/impl.py

cherrypick Matrix repr support

4ce08c8

AD1024 mentioned this pull request Aug 15, 2022

[Lang] Enable matrix representation in Frontend/CHI IR #5551

Closed

AD1024 changed the title ~~[Lang] Enable definition of local matrices/vectors~~ [Lang] Enable definition of local matrices/vectors Aug 15, 2022

pre-commit-ci bot and others added 5 commits August 15, 2022 17:51

[pre-commit.ci] auto fixes from pre-commit.com hooks

549a359

for more information, see https://pre-commit.ci

matrix assign

07a4dc1

Merge branch 'matrix-repr' of github.com:AD1024/taichi into matrix-repr

d2264f4

move checks to caller side

efca3f0

[pre-commit.ci] auto fixes from pre-commit.com hooks

82c9413

for more information, see https://pre-commit.ci

AD1024 marked this pull request as ready for review August 15, 2022 18:54

AD1024 added 2 commits August 15, 2022 15:34

use ==

38ec750

merge and format

13159fd

jim19930609 reviewed Aug 17, 2022

View reviewed changes

AD1024 and others added 5 commits August 17, 2022 13:37

refine impl

9c91103

[pre-commit.ci] auto fixes from pre-commit.com hooks

28f3e0a

for more information, see https://pre-commit.ci

no long in use

bf719a3

Merge branch 'matrix-repr' of github.com:AD1024/taichi into matrix-repr

72e8f26

add some comments

65199ea

jim19930609 approved these changes Aug 19, 2022

View reviewed changes

strongoier reviewed Aug 22, 2022

View reviewed changes

AD1024 and others added 2 commits August 23, 2022 19:17

get rid of always-true condition

cbf1ea8

Co-authored-by: Yi Xu <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

4c8d6b7

for more information, see https://pre-commit.ci

AD1024 added 3 commits August 23, 2022 19:40

save

1a9df8c

some fixes for print and matrix expr

834699e

fix codegen alloca size

23d7bf7

strongoier reviewed Aug 24, 2022

View reviewed changes

taichi/transforms/alg_simp.cpp Outdated Show resolved Hide resolved

taichi/ir/type_utils.cpp Show resolved Hide resolved

taichi/codegen/llvm/codegen_llvm.cpp Show resolved Hide resolved

taichi/codegen/llvm/codegen_llvm.cpp Outdated Show resolved Hide resolved

AD1024 added 2 commits August 24, 2022 02:34

unsupport empty matrix

6a8a8cb

only check and cast elements

08926ef

AD1024 and others added 18 commits August 24, 2022 03:02

clean-up

5421fe1

clean-up cse code

b9fd3a9

breaks ci; keep as original impl

43a456a

handle alloca

78ad14a

move checks to front

40825f4

Merge branch 'master' into matrix-repr

88d01b6

reuse code

f395d2a

Revert "clean-up cse code"

2a6a8e6

This reverts commit b9fd3a9.

clean up together

7f8ca37

[pre-commit.ci] auto fixes from pre-commit.com hooks

988abb3

for more information, see https://pre-commit.ci

also checks for tlctx

93b3a03

Merge branch 'matrix-repr' of github.com:AD1024/taichi into matrix-repr

13d2efd

format

b2e101a

fix codegen: allocate pointer to vector

6fcf070

[pre-commit.ci] auto fixes from pre-commit.com hooks

f43d2a8

for more information, see https://pre-commit.ci

check real matrix when allocating memory

c613318

Merge branch 'matrix-repr' of github.com:AD1024/taichi into matrix-repr

41b6641

format and fix tc for variable holding matrix expression

9fc758d

strongoier reviewed Aug 25, 2022

View reviewed changes

taichi/transforms/alg_simp.cpp Outdated Show resolved Hide resolved

taichi/ir/frontend_ir.cpp Outdated Show resolved Hide resolved

taichi/analysis/data_source_analysis.cpp Outdated Show resolved Hide resolved

AD1024 added 2 commits August 25, 2022 00:23

refactor: change to make_local_matrix which returns only an Expr; p…

f635b7c

…ostpone var alloca to ast transformer

get rid of duplicated check

f82dc25

strongoier reviewed Aug 25, 2022

View reviewed changes

taichi/transforms/alg_simp.cpp Outdated Show resolved Hide resolved

strongoier reviewed Aug 25, 2022

View reviewed changes

python/taichi/lang/impl.py Outdated Show resolved Hide resolved

AD1024 added 2 commits August 25, 2022 01:42

save changes

bd68c23

format

5d00c98

strongoier reviewed Aug 25, 2022

View reviewed changes

taichi/ir/frontend_ir.cpp Outdated Show resolved Hide resolved

also rename cxx part

3451397

strongoier approved these changes Aug 25, 2022

View reviewed changes

taichi/python/export_lang.cpp Outdated Show resolved Hide resolved

python/taichi/lang/impl.py Outdated Show resolved Hide resolved

Apply suggestions from code review

5ed0e93

strongoier merged commit 9d347f6 into taichi-dev:master Aug 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lang] Enable definition of local matrices/vectors #5782

[Lang] Enable definition of local matrices/vectors #5782

AD1024 commented Aug 15, 2022

netlify bot commented Aug 15, 2022 •

edited

Loading

jim19930609 commented Aug 17, 2022

jim19930609 left a comment

strongoier left a comment

AD1024 commented Aug 23, 2022

strongoier left a comment

[Lang] Enable definition of local matrices/vectors #5782

[Lang] Enable definition of local matrices/vectors #5782

Conversation

AD1024 commented Aug 15, 2022

netlify bot commented Aug 15, 2022 • edited Loading

✅ Deploy Preview for docsite-preview ready!

jim19930609 commented Aug 17, 2022

jim19930609 left a comment

Choose a reason for hiding this comment

strongoier left a comment

Choose a reason for hiding this comment

AD1024 commented Aug 23, 2022

strongoier left a comment

Choose a reason for hiding this comment

netlify bot commented Aug 15, 2022 •

edited

Loading