add mgpcg example #573
Merged
add mgpcg example #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome!!! I'll do a smoke simulator example based on it! |
|
Update: the new python frontend with template meta-programming and immediate tensor placement has allowed me to greatly simplify the MGPCG solver based on your version: 37610ff |
|
About reduction optimization: #576 I'm working on systematically developing a set of IR extensions for this purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted your mgpcg example to to python. Interestingly, the profiler shows that the reduction kernels take the majority of the computational time. Perhaps some optimization work needs to go into these.