Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulkan] Fixed query pool invalid usage #5717

Merged
merged 6 commits into from
Aug 12, 2022

Conversation

PENGUINLIONG
Copy link
Member

This PR fixed a validation issue that query pools are not correctly reset before use (for on-device execution time measurement). Also fixed a bit of compilation issue.

@netlify
Copy link

netlify bot commented Aug 10, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 32a9c5c
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62f37f3a5c030100099ae55f
😎 Deploy Preview https://deploy-preview-5717--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

taichi/rhi/vulkan/vulkan_device.cpp Show resolved Hide resolved
@PENGUINLIONG PENGUINLIONG merged commit e7a900a into taichi-dev:master Aug 12, 2022
@PENGUINLIONG PENGUINLIONG deleted the fix-profiling1 branch August 12, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants