Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autodiff] Print more specific error message that autodiff does not support to_numpy #5630

Merged
merged 6 commits into from
Aug 6, 2022

Conversation

PhrygianGates
Copy link
Contributor

@PhrygianGates PhrygianGates commented Aug 4, 2022

Related issue = #4473

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit a4d4ec3
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62ecfee3dae5440009f826d9
😎 Deploy Preview https://deploy-preview-5630--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2022

CLA assistant check
All committers have signed the CLA.

@PhrygianGates PhrygianGates changed the title [autodiff] print more specific error message that autodiff does not s… [autodiff] Print more specific error message that autodiff does not support to_numpy Aug 4, 2022
@erizmr erizmr self-requested a review August 4, 2022 10:09
Copy link
Contributor

@erizmr erizmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BTW, could you please re-sign the CLA? it seems the github id is not correctly filled.

@PhrygianGates
Copy link
Contributor Author

ok!

@yuanming-hu
Copy link
Member

@PhrygianGates Thank you so much for your great contribution, and welcome to the Taichi community! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants