Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dx12] Drop code for dx12 aot. #5596

Closed
wants to merge 4 commits into from

Conversation

python3kgae
Copy link
Contributor

This change add Arch::dx12 for DirectX12.
rhi, runtime and codegen are added for dx12 with minimal support to run aot.
One AOT test is added to test dxil container generation.

The codegen will not generate legal dxil yet.
More passes are needed to lower taichi generated llvm IR to DXIL in both dx12 codegen and llvm DirectX target.

TaskCodeGenLLVMDX12 inherits from TaskCodeGenLLVM to get llvm module generated.
But KernelCodeGenDX12 inherits from KernelCodeGen instead of KernalCodeGenLLVM.
Because the output should be dx container instead of llvm module.

Related issue = #5276

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 82ea04b
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62ecade48adeb9000834e229

python3kgae and others added 3 commits August 3, 2022 09:58
This change add Arch::dx12 for DirectX12.
rhi, runtime and codegen are added for dx12 with minimal support to run aot.
One AOT test is added to test dxil container generation.

The codegen will not generate legal dxil yet.
More passes are needed to lower taichi generated llvm IR to DXIL in both dx12 codegen and llvm DirectX target.

TaskCodeGenLLVMDX12 inherits from TaskCodeGenLLVM to get llvm module generated.
But KernelCodeGenDX12 inherits from KernelCodeGen instead of KernalCodeGenLLVM.
Because the output should be dx container instead of llvm module.
@jim19930609
Copy link
Contributor

Hi python3kgae,
Thank you so much for enabling the DX12 backend together with the AOT support! This is super!

Just for review purpose, was wondering if you may break this PR into separate smaller PRs so that it's easy to review and make comments? Thanks in advance!

@jim19930609
Copy link
Contributor

Hi python3kgae, Thank you so much for enabling the DX12 backend together with the AOT support! This is super!

Just for review purpose, was wondering if you may break this PR into separate smaller PRs so that it's easy to review and make comments? Thanks in advance!

Just in case of need, you can probably refer to #4800. However, there's no concrete rule on how we should split our PR.

@python3kgae
Copy link
Contributor Author

Close to split the PR.

Hi python3kgae, Thank you so much for enabling the DX12 backend together with the AOT support! This is super!

Just for review purpose, was wondering if you may break this PR into separate smaller PRs so that it's easy to review and make comments? Thanks in advance!

Sure. I'll close this PR and make small PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants