Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Build Android export core #5409

Merged
merged 2 commits into from
Aug 3, 2022
Merged

[ci] Build Android export core #5409

merged 2 commits into from
Aug 3, 2022

Conversation

feisuzhu
Copy link
Contributor

Related issue = #5408

@netlify
Copy link

netlify bot commented Jul 13, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 01d8373
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62e9ee59f9b7e00008ecdc76
😎 Deploy Preview https://deploy-preview-5409--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@feisuzhu feisuzhu force-pushed the feat/ci-android-export-core branch 7 times, most recently from 0b058c3 to 918640c Compare July 25, 2022 07:50
@feisuzhu feisuzhu force-pushed the feat/ci-android-export-core branch 8 times, most recently from 235af59 to 5b79ff4 Compare August 2, 2022 10:10
@feisuzhu feisuzhu force-pushed the feat/ci-android-export-core branch from 5b79ff4 to 27f47a9 Compare August 2, 2022 10:12
@feisuzhu feisuzhu marked this pull request as ready for review August 2, 2022 13:54
@feisuzhu feisuzhu requested review from ailzhang and qiao-bo August 2, 2022 13:54
qiao-bo
qiao-bo reviewed Aug 3, 2022
View reviewed changes
Copy link
Contributor

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

qiao-bo
qiao-bo approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ailzhang
ailzhang approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! (as discussed offline, let's rename libcommon.sh in the followup PR :P

@ailzhang ailzhang merged commit 2a19a98 into taichi-dev:master Aug 3, 2022
@feisuzhu feisuzhu deleted the feat/ci-android-export-core branch August 3, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiao-bo qiao-bo qiao-bo approved these changes

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feisuzhu @ailzhang @qiao-bo