Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not instantiate Metal root buffer if it's not used #532

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Feb 25, 2020

Related issue id = #396

Mostly code cleanup..

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not sure if my review will help improve this PR, but everything looks good to me. :-)

@k-ye k-ye force-pushed the root branch 2 times, most recently from b06357a to b65b396 Compare February 26, 2020 23:39
@k-ye k-ye merged commit 245d760 into taichi-dev:master Feb 27, 2020
@k-ye k-ye deleted the root branch February 27, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants