[Lang] [type] Refine SNode with quant 2/n: Enable struct for on bit_array with bit_vectorize off #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray with bit_vectorize off
✅ Deploy Preview for docsite-preview canceled.
|
for more information, see https://pre-commit.ci
ailzhang
approved these changes
Jun 27, 2022
Yep :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #4857
Previous implementation of struct for on
bit_arrayassumesbit_vectorizeis on, and you cannot access a single element inside. However,bit_vectorizeis designed for 0/1 arrays, which is not suitable for normal cases. This PR turnsbit_vectorizeoff by default, and supports reading/writing a single element inside struct for onbit_array.Notes:
bit_vectorize == 1means 1-bit vectorization, which is indeed saying thatbit_vectorizeis offlistgenfor thebit_arraySNode whenbit_vectorizeis off