Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taichi build on macOS with Python 3.6 to Python 3.8 covered #409 #513

Merged
merged 5 commits into from
Feb 22, 2020

Conversation

Detavern
Copy link
Contributor

Related issue id = #409

@Detavern
Copy link
Contributor Author

Hi, as far as I know, python builds are not available on the macOS environment, which is same even using generic travis builds.

Currently, python version on osx depends on Xcode image version.

In my approach, homebrew and pyenv are used to build specific python version on macOS (quite tricky).

Additionally, since python 3.8, platform.platform() will use platform.mac_ver() instead.

# Python 3.6, 3.7
In [1]: import platform

In [2]: platform.platform()
Out[2]: 'Darwin-19.3.0-x86_64-i386-64bit'

# Python 3.8
In [1]: import platform

In [2]: platform.platform()
Out[2]: 'macOS-10.15.3-x86_64-i386-64bit'

Finally covered 🍺

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!! This will help a lot of Mac users!

@yuanming-hu yuanming-hu merged commit 993d9f4 into taichi-dev:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants