Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Error] Provide source code info in warnings #4840

Merged
merged 7 commits into from
Apr 22, 2022
Merged

[Error] Provide source code info in warnings #4840

merged 7 commits into from
Apr 22, 2022

Conversation

strongoier
Copy link
Contributor

@strongoier strongoier commented Apr 22, 2022 •
edited
Loading

Related issue = fix #4839

After this PR, the warning in #4839 becomes:

[Taichi] version 1.0.1, llvm 10.0.0, commit 491f0533, linux, python 3.8.10
[Taichi] Starting on arch=x64
[W 04/22/22 13:30:22.558 194123] [type_check.cpp:visit@223] [$11] Global store may lose precision: i32 <- f32
On line 9 of file "tttr.py", in bug_gen:
    x[None] = 1.0
    ^^^^^^^^^^^^^

@netlify
Copy link

netlify bot commented Apr 22, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 4448e8e
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/626241b9cc2509000887bfc9
😎 Deploy Preview https://deploy-preview-4840--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ailzhang
ailzhang approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit db99acd into taichi-dev:master Apr 22, 2022
@strongoier strongoier mentioned this pull request Apr 22, 2022
Closed
@strongoier strongoier deleted the fix-4250-1 branch April 22, 2022 06:59
@strongoier strongoier mentioned this pull request Apr 26, 2022
Merged
k-ye pushed a commit to k-ye/taichi that referenced this pull request May 5, 2022
@strongoier @pre-commit-ci @k-ye
[Error] Provide source code info in warnings (taichi-dev#4840)
1dcee25 
* Add SrcInfoGuard

* Change stack_info

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove redundant 'at'

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@k-ye k-ye Awaiting requested review from k-ye

@lin-hitonami lin-hitonami Awaiting requested review from lin-hitonami

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type cast warnings don't contain source code info
2 participants
@strongoier @ailzhang