Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] Deprecate ext_arr/any_arr in favor of types.ndarray #4598

Merged
merged 6 commits into from
Mar 23, 2022
Merged

[Lang] Deprecate ext_arr/any_arr in favor of types.ndarray #4598

merged 6 commits into from
Mar 23, 2022

Conversation

strongoier
Copy link
Contributor

@strongoier strongoier commented Mar 22, 2022 •
edited
Loading

Related issue = #4085

Use ti.types.ndarray() in place of ti.ext_arr() or ti.any_arr().

@netlify
Copy link

netlify bot commented Mar 22, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 33c332e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62397134d967a0000845d998

😎 Browse the preview: https://deploy-preview-4598--docsite-preview.netlify.app

@strongoier
Copy link
Contributor Author

/format

@strongoier
Copy link
Contributor Author

/format

lin-hitonami
lin-hitonami approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

k-ye
k-ye reviewed Mar 23, 2022
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ailzhang
ailzhang approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ailzhang ailzhang merged commit 223bf6c into taichi-dev:master Mar 23, 2022
@strongoier strongoier deleted the types-ndarray branch March 23, 2022 05:54
@RuRo RuRo mentioned this pull request Mar 30, 2022
Closed
@strongoier strongoier mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lin-hitonami lin-hitonami lin-hitonami approved these changes

@k-ye k-ye k-ye approved these changes

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@strongoier @ailzhang @k-ye @lin-hitonami @taichi-gardener