-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Generate manylinux2014-compatible wheels with CUDA backend in release workflow #4550
Conversation
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: 8316cb6 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/6231a189eb0f530008940e2c |
46563a5
to
8108e4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM but is there any chance to merge it into the matrix of build and test linux?
I see the only difference is the image name and TI_WANTED_ARCHS
(does it make difference if we make them the same for this env var?)
I agree that there are some similarities, but there are still other differences like:
I am not sure if putting these together will make things clearer. |
@strongoier Ok then that is fine to keep it as it is now. I didn't compare them carefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! In the future, we might need to think about adding to test.yml as well.
Related issue = close #4395
The docker image produced by #4491 was uploaded as
registry.taichigraphics.com/taichidev-manylinux2014-cuda:v0.0.0
. Then this PR adds a job in release workflow to build and test the new wheel with CPU and CUDA backends in that image.The new wheel is named as
taichi-0.9.2-cp38-cp38-manylinux2014_x86_64.whl
, while the original one (with OpenGL/Vulkan support as well) is renamed astaichi-0.9.2-cp38-cp38-manylinux_2_27_x86_64.whl
(the original name withmanylinux1
is wrong).pip install
will choose the wheel closest to the user platform.