Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix metal linker error when TI_WITH_METAL=OFF #4469

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

qiao-bo
Copy link
Contributor

@qiao-bo qiao-bo commented Mar 7, 2022

Related issue = #4464

This PR fixes the following linker error

/usr/bin/ld: CMakeFiles/taichi_isolated_core.dir/taichi/program/program.cpp.o: in function `taichi::lang::Program::Program(taichi::Arch)':
program.cpp:(.text+0x561): undefined reference to `taichi::lang::metal::is_metal_api_available()'
/usr/bin/ld: program.cpp:(.text+0x581): undefined reference to `taichi::lang::MetalProgramImpl::MetalProgramImpl(taichi::lang::CompileConfig&)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

To reproduce: #4464 (comment)

@qiao-bo qiao-bo requested review from ailzhang and k-ye March 7, 2022 10:48
@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: fbb2ff8

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/6225e2f6b576c90008d3af42

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ailzhang ailzhang merged commit 475ebf2 into taichi-dev:master Mar 7, 2022
@qiao-bo qiao-bo deleted the metal branch March 7, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants