Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Error] Add error messages for wrong type annotations of literals #4462

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

strongoier
Copy link
Contributor

Related issue = fixes #4451

In fact, the problem in #4451 is already solved by #4440. This PR further adds error messages under our new type annotation mechanism for literals.

@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 95209a5

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/6225b8aebcd7620007dfedeb

😎 Browse the preview: https://deploy-preview-4462--docsite-preview.netlify.app

@strongoier
Copy link
Contributor Author

/format

Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 2f4f457 into taichi-dev:master Mar 7, 2022
@strongoier strongoier deleted the fix-4451 branch March 7, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Float initialization with integer literal regression
3 participants