Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javascript] [cuda] Only spawn memory allocator daemon when CUDA is enabled (JS 8/n) #4115

Closed
wants to merge 3 commits into from

Conversation

AmesingFlank
Copy link
Collaborator

Related issue = #3781

The daemon is only used for allocation memory in CUDA. (Actually, do we even use that in CUDA anymore, we have switched completely to pre-allocation right?)

@vercel
Copy link

vercel bot commented Jan 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/CBUrXq9UziwubVpZhYZ68LhsZK7u
✅ Preview: Canceled

[Deployment for 46d300e canceled]

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 46d300e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f0b900c6cbc200070ae79f

😎 Browse the preview: https://deploy-preview-4115--docsite-preview.netlify.app

@qiao-bo
Copy link
Contributor

qiao-bo commented Jan 26, 2022

Memory allocation in CUDA/CPU has been switched to using preallocated. The memory pool is not used IIUC. ;/

@AmesingFlank
Copy link
Collaborator Author

AmesingFlank commented Jan 26, 2022

Memory allocation in CUDA/CPU has been switched to using preallocated. The memory pool is not used IIUC. ;/

Right! Thanks for confirming.

Actually I think this memory pool is still used for allocating things like host-side result buffer. But we should consider removing the daemon entirely.

Created #4135 to track this.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AmesingFlank
Copy link
Collaborator Author

CI on macOS keeps failing.. interesting. Not sure why this change would affect macOS. Will investigate.

@feisuzhu
Copy link
Contributor

Closing ancient PR

@feisuzhu feisuzhu closed this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants