-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[javascript] [cuda] Only spawn memory allocator daemon when CUDA is enabled (JS 8/n) #4115
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/CBUrXq9UziwubVpZhYZ68LhsZK7u [Deployment for 46d300e canceled] |
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 46d300e 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f0b900c6cbc200070ae79f 😎 Browse the preview: https://deploy-preview-4115--docsite-preview.netlify.app |
Memory allocation in CUDA/CPU has been switched to using preallocated. The memory pool is not used IIUC. ;/ |
Right! Thanks for confirming. Actually I think this memory pool is still used for allocating things like host-side result buffer. But we should consider removing the daemon entirely. Created #4135 to track this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CI on macOS keeps failing.. interesting. Not sure why this change would affect macOS. Will investigate. |
Closing ancient PR |
Related issue = #3781
The daemon is only used for allocation memory in CUDA. (Actually, do we even use that in CUDA anymore, we have switched completely to pre-allocation right?)