[test] Replace make_temp_file with tempfile #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: #3782 `make_temp_file` can be easily replaced by native python tempfile so let's just use tempfile. [ghstack-poisoned]
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/4kLCib2iZbjb9GmujmgDtorFCHbA |
This was referenced Jan 25, 2022
Related: #3782 `make_temp_file` can be easily replaced by native python tempfile so let's just use tempfile. [ghstack-poisoned]
Related: #3782 `make_temp_file` can be easily replaced by native python tempfile so let's just use tempfile. [ghstack-poisoned]
ailzhang
pushed a commit
that referenced
this pull request
Jan 25, 2022
Related: #3782 Originally I want to delete make_temp_file and use tempfile directly. But on windows ti.imwrite will error on a file with an open handle. So we do need a helper function to handle the process of open -> close temp file just to get a name. ghstack-source-id: 14eb26d13c11e607c76420f69e0c66f68eb7ef56 Pull Request resolved: #4111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Related: #3782
make_temp_filecan be easily replaced by native python tempfile solet's just use tempfile.