[javascript] Avoid all usages of glfw/vulkan/volk when TI_EMSCRIPTENED (JS 5/n) #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/ASxXoA4wZU7WYsGer5hiQZHndeCm [Deployment for 2976563 canceled] |
AmesingFlank
changed the title
|
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: 2976563 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61ef51cb5cd11300071faf8e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3781
Avoid all usages of glfw/vulkan/volk when TI_EMSCRIPTENED. To build the JS frontend, we will only be using the AOT features in Taichi. However, Taichi's vulkan backend will try to invoke glfw/vulkan/volk stuff even when using AOT. This PR guards that from happening.