Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javascript] Support compiling taichi under x86 (JS 4/n) #4107

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

AmesingFlank
Copy link
Collaborator

Related issue = #3781

When building with emscripten, the target architecture is x86. This PR enables supports for it.

Surprisingly, this is the only problem due to x86 that I've encountered while building and using an emscriptened version of taichi. This tells us that even for the python version of taichi, we can expect a large portion of it to work if we compile it for x86.

@vercel
Copy link

vercel bot commented Jan 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/AZPvEmAYAm28Eg57QP72WyXZ1Qsi
✅ Preview: Canceled

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: 13658d1

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61ef448cb0837e000885e14c

@AmesingFlank AmesingFlank requested review from bobcao3 and k-ye January 25, 2022 00:30
Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good, not sure why we are limited to x64 before, so maybe needs an double check

@AmesingFlank AmesingFlank merged commit 8ea0eb8 into taichi-dev:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants