Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove exposure of internal functions in taichi.lang.ops #4101

Merged
merged 7 commits into from
Jan 25, 2022

Conversation

lin-hitonami
Copy link
Contributor

@lin-hitonami lin-hitonami commented Jan 24, 2022

Related issue = #4087, #3782

Renamed ti.ti_max and ti.ti_min to ti.max and ti.min, and added deprecate warnings to builtin max and min.
Deprecated element-wise select operation in conditional expression.

@vercel
Copy link

vercel bot commented Jan 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/CKgV8VUqgnE84BAUavLDAK6gYW62
✅ Preview: https://taichi-git-fork-lin-hitonami-ops-taichi-api-docs-preview.vercel.app

@netlify
Copy link

netlify bot commented Jan 24, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: 76bb2a5

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61ef9f7761d50000084e5cff

@lin-hitonami lin-hitonami changed the title [refactor] Remove exposure of internal functions in taichi.lang.ops [Refactor] Remove exposure of internal functions in taichi.lang.ops Jan 25, 2022
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lin-hitonami lin-hitonami merged commit a86f256 into taichi-dev:master Jan 25, 2022
@lin-hitonami lin-hitonami deleted the ops branch January 26, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants