Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Add doc about difference between taichi and python programs #3996

Merged
merged 25 commits into from
Jan 25, 2022
Merged

[doc] Add doc about difference between taichi and python programs #3996

merged 25 commits into from
Jan 25, 2022

Conversation

lin-hitonami
Copy link
Contributor

Related issue = #

@netlify
Copy link

netlify bot commented Jan 11, 2022 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 52164bb

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61dfe1354c9b9b0008471aed

😎 Browse the preview: https://deploy-preview-3996--jovial-fermat-aa59dc.netlify.app

@lin-hitonami lin-hitonami force-pushed the difference_taichi_python branch from 4d14d09 to d187cc0 Compare January 13, 2022 03:50
@vercel
Copy link

vercel bot commented Jan 14, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/44dQoBvW9RF9VL3YmQg9TqnTnKat
✅ Preview: Canceled

[Deployment for 3ee2e5c canceled]

@netlify
Copy link

netlify bot commented Jan 14, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 3ee2e5c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61e8f3e41af61b000850bbea

😎 Browse the preview: https://deploy-preview-3996--docsite-preview.netlify.app

Leonz5288
Leonz5288 reviewed Jan 14, 2022
View reviewed changes
Copy link
Contributor

@Leonz5288 Leonz5288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions on texts.

@lin-hitonami lin-hitonami marked this pull request as ready for review January 17, 2022 09:29
@lin-hitonami @writinwaters
Apply suggestions from code review
a19de86 
Co-authored-by: Vissidarte-Herman <[email protected]>
@lin-hitonami
Copy link
Contributor Author

/format

ailzhang
ailzhang approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lin-hitonami lin-hitonami merged commit 42b0768 into taichi-dev:master Jan 25, 2022
@lin-hitonami lin-hitonami deleted the difference_taichi_python branch January 25, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@writinwaters writinwaters writinwaters approved these changes

@ailzhang ailzhang ailzhang approved these changes

@k-ye k-ye Awaiting requested review from k-ye

@Leonz5288 Leonz5288 Awaiting requested review from Leonz5288

@strongoier strongoier Awaiting requested review from strongoier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lin-hitonami @ailzhang @k-ye @Leonz5288 @writinwaters @taichi-gardener