-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lang] Support annotated assignment #3709
Conversation
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: 638fb92 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61ae6f0c4f2ad30008d6befc |
Hi @woooodyye. Which PR is the version you would like to get reviewed, this or #3701? |
hi, can I get this PR draft reviewed ? I think #3701 has formatting issues. Thanks. @strongoier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
/format |
please ignore the review request |
Right Now. Since annotations are not considered as variables, we need to explicitly define a primitive type as a value for the primitive types to be considered as variables. For Instance: Instead, we need to do something like
Note: the primitive type you declare doesn't necessarily need to be the type annotation you want to use, It's totally fine to do
The whole point of this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Only some nits.
Co-authored-by: Yi Xu <[email protected]>
Co-authored-by: Yi Xu <[email protected]>
…to typed-assign "fixed formatting and naming error"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related issue = #2610