Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] Add async_mode restriction to ti.sync() of external_arrays in class Kernel #3535

Merged

Conversation

yolo2themoon
Copy link
Contributor

Related issue = #1778 #2638

@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: a3d7193

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/619b6a1da9365900085f7850

😎 Browse the preview: https://deploy-preview-3535--jovial-fermat-aa59dc.netlify.app

@yolo2themoon yolo2themoon changed the title [perf] Remove ti.sync() for external_arrays from class Kernel [perf] Add async_mode restriction to ti.sync() of external_arrays in class Kernel Nov 17, 2021
@yolo2themoon
Copy link
Contributor Author

/format

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yolo2themoon yolo2themoon merged commit 1ca4c40 into taichi-dev:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants