Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pypi] Add PEP 517 build specification #3495

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

frostming
Copy link
Collaborator

Related issue = #

Add a PEP 517 style build specification together with several improvements on the project metadata:

  1. Specify a minimum build requirements
  2. Remove pybind11 from install_requires, it is a build requirement
  3. Remove requirements.txt as it isn't used anywhere
  4. Fix the setup.cfg so that README is included correctly. Current releases don't have description
  5. Remove the check of GitPython from the CMake file, it is not required in build time.

@netlify
Copy link

netlify bot commented Nov 13, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 581955f

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/618fd291f5a83800076d95e0

@frostming frostming changed the title [PyPI][Release] Add PEP 517 build specification [PyPI] [Release] Add PEP 517 build specification Nov 13, 2021
@frostming frostming changed the title [PyPI] [Release] Add PEP 517 build specification [Release] Add PEP 517 build specification Nov 13, 2021
@frostming frostming changed the title [Release] Add PEP 517 build specification [release] Add PEP 517 build specification Nov 14, 2021
@frostming frostming changed the title [release] Add PEP 517 build specification [pypi] Add PEP 517 build specification Nov 14, 2021
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee! Thanks!

@ailzhang ailzhang merged commit 0f6477a into taichi-dev:master Nov 14, 2021
@frostming frostming deleted the build-metadata branch November 14, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants