Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Enforce type check for all expressions #3461

Merged
merged 5 commits into from
Nov 14, 2021

Conversation

strongoier
Copy link
Contributor

Related issue = #3301

This PR adds type_check for remaining expressions and removes all TODO: assert no unknowns after type_check for all expressions are implemented.

@netlify
Copy link

netlify bot commented Nov 11, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 4b114c1

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/618f91c60408c90007f67496

😎 Browse the preview: https://deploy-preview-3461--jovial-fermat-aa59dc.netlify.app

@strongoier
Copy link
Contributor Author

/format

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

taichi/ir/frontend_ir.cpp Outdated Show resolved Hide resolved
@strongoier
Copy link
Contributor Author

/format

@ailzhang ailzhang merged commit a4281a1 into taichi-dev:master Nov 14, 2021
@strongoier strongoier deleted the type-check-func branch November 15, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants