[OpenGL] Add mem_offset_in_parent to serialized file in AOT. #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for jovial-fermat-aa59dc ready! 🔨 Explore the source changes: 00c58ee 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6188e75394a113000714d2f0 😎 Browse the preview: https://deploy-preview-3418--jovial-fermat-aa59dc.netlify.app |
k-ye
reviewed
Nov 8, 2021
ailzhang
force-pushed
the
opengl_mem_offset
branch
2 times, most recently
from
c2e3d53 to
78dba93
Compare
k-ye
approved these changes
Nov 8, 2021
| @@ -31,5 +31,31 @@ void AotModuleBuilder::add_kernel_template(const std::string &identifier, | |||
| add_per_backend_tmpl(identifier, key, kernel); | |||
| } | |||
|
|
|||
| bool AotModuleBuilder::all_fields_are_dense_in_container( | |||
There was a problem hiding this comment.
I feel like this can have an even wider applicability, but the base AOT builder seems good enough :-)
There was a problem hiding this comment.
yup agreed! I'd just keep this here for now since we know it'll be useful for all aot backends for sure. Later we can move it to other places if needed :D
taichi/program/aot_module_builder.h
Outdated
| @@ -48,6 +48,10 @@ class AotModuleBuilder { | |||
| virtual void add_per_backend_tmpl(const std::string &identifier, | |||
| const std::string &key, | |||
| Kernel *kernel) = 0; | |||
|
|
|||
| bool all_fields_are_dense_in_container(const SNode *container); | |||
ailzhang
force-pushed
the
opengl_mem_offset
branch
from
78dba93 to
00c58ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #