[opengl] Save opengl aot data in json format. #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: 56da36b 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61887bfb8369ad0007d1897a |
k-ye
reviewed
Nov 8, 2021
| @@ -636,9 +638,25 @@ class TextSerializer : public Serializer { | |||
| this->process(key, t); | |||
| } | |||
|
|
|||
| // Entry to make an AOT json file | |||
| template <typename T> | |||
| void serialize_to_json(const char *key, const T &t) { | |||
There was a problem hiding this comment.
Hmm, is this all we need for generating conforming JSON... ?
There was a problem hiding this comment.
Since our output structure is kinda stable so yea it's pretty simple to generate a conforming JSON. To simplify the problem, I didn't use [] at all, but keep using {} for now which is sufficient for simple cases. :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
TextSerializerto output json format instead of a customized format. I tried to not introduce any extra dependency like jsoncpp but just make our output json compliant. (two regex tricks are used :P).glslfile and only saves the filename in json.Example generated aot json file: https://gist.github.com/ailzhang/48b6126cabae2e9f2d35da02b210a719
Currently I only changed opengl backend to json, will change metal later together with enabling its tests.