Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Update "get_largest_pot" in scalar.h + Bug Fix #3405

Merged
merged 7 commits into from
Nov 7, 2021
Merged

[misc] Update "get_largest_pot" in scalar.h + Bug Fix #3405

merged 7 commits into from
Nov 7, 2021

Conversation

NiclasSchwalbe
Copy link
Contributor

Find the largest potence faster.

Related issue = #

Find the largest potence faster.
@netlify
Copy link

netlify bot commented Nov 5, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: c356971

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6186ea1822bc1e000711fe0f

@NiclasSchwalbe
Copy link
Contributor Author

/format

@yuanming-hu yuanming-hu changed the title Update scalar.h [misc] Update "get_largest_pot" in scalar.h Nov 6, 2021
@NiclasSchwalbe
Copy link
Contributor Author

/format

Manually edited formatting errors.
@NiclasSchwalbe NiclasSchwalbe changed the title [misc] Update "get_largest_pot" in scalar.h [misc] Update "get_largest_pot" in scalar.h + Bug Fix Nov 6, 2021
@NiclasSchwalbe
Copy link
Contributor Author

-- Fixed a = 1, where 0 must be returned

retry workflow
retry workflow
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@k-ye k-ye merged commit 0e4ca37 into taichi-dev:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants