Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulkan] Fix GGUI #3330

Merged
merged 3 commits into from
Oct 31, 2021
Merged

[vulkan] Fix GGUI #3330

merged 3 commits into from
Oct 31, 2021

Conversation

AmesingFlank
Copy link
Collaborator

@AmesingFlank AmesingFlank commented Oct 30, 2021

fixes #3327

GGUI started crashing since #3253, but that PR wasn't the issue. The real problem is that the vk_has_external_memory flag wasn't set properly.

@AmesingFlank AmesingFlank requested a review from bobcao3 October 30, 2021 15:01
@netlify
Copy link

netlify bot commented Oct 30, 2021

❌ Deploy Preview for jovial-fermat-aa59dc failed.

🔨 Explore the source changes: 0612fb8

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/617dd9904b371b000721fbcb

@AmesingFlank AmesingFlank requested review from k-ye and ailzhang October 30, 2021 15:02
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GGUI] GGUI program cann't run on 0.8.4.
3 participants