Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulkan] Support for ti.u8 in vulkan #3247

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Conversation

AmesingFlank
Copy link
Collaborator

This adds support for ti.u8 in vulkan, and thereby fixes canvas.set_image() in ggui when working with vk compute backend.

@netlify
Copy link

netlify bot commented Oct 22, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 1768837

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6172087abd5e080008e8d14b

Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe put in int16/uint16 as well?

Copy link
Contributor

@g1n0st g1n0st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit 6aa2fd1 into taichi-dev:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants