Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Example] An implicit mass spring demo with sparse matrix #3116

Merged
merged 13 commits into from
Oct 11, 2021
Merged

[Example] An implicit mass spring demo with sparse matrix #3116

merged 13 commits into from
Oct 11, 2021

Conversation

FantasyVR
Copy link
Collaborator

Related issue = #2906

@netlify
Copy link

netlify bot commented Oct 8, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 80b2187

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6163a62a532f8800079e6e91

@FantasyVR FantasyVR marked this pull request as ready for review October 8, 2021 11:17
@FantasyVR
Copy link
Collaborator Author

/format

@FantasyVR
Copy link
Collaborator Author

/format

1 similar comment
@FantasyVR
Copy link
Collaborator Author

/format

@AmesingFlank
Copy link
Collaborator

Try rebasing onto master to fix the format.

@FantasyVR
Copy link
Collaborator Author

/format

@strongoier strongoier merged commit e8e2f9a into taichi-dev:master Oct 11, 2021
Hanke98
Hanke98 approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@Hanke98 Hanke98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Learned a lot from this demo.

@FantasyVR FantasyVR deleted the implicit_ms branch October 11, 2021 13:05
@Hanke98 Hanke98 mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye left review comments

@Hanke98 Hanke98 Hanke98 approved these changes

@strongoier strongoier strongoier approved these changes

Assignees

@ltt1598 ltt1598

@yuanming-hu yuanming-hu

@k-ye k-ye

@Hanke98 Hanke98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@FantasyVR @AmesingFlank @strongoier @k-ye @Hanke98 @ltt1598 @yuanming-hu @taichi-gardener