-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example] A stable fluid demo with sparse matrix #3081
Conversation
✔️ Deploy Preview for jovial-fermat-aa59dc ready! 🔨 Explore the source changes: 9634819 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/615c38cd2a06670008b651a8 😎 Browse the preview: https://deploy-preview-3081--jovial-fermat-aa59dc.netlify.app |
Thank you!
We had some discussions about this before, and I believe ultimately we need a feature like this to avoid copying. We probably need to design a set of reasonable APIs to reshape the solution from 1D to 2D. For now, I think we can stick to the numpy solution :-)
Sounds like a good idea! |
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very cool!
Co-authored-by: Yuanming Hu <[email protected]>
- @strongoier, FYI our type system work should take into account the ability to do zero-copy with other frameworks. NDArray is a glimpse of this direction :-) |
/format |
Related issue = #2906 #2792
In this pr, we show a stable fluid demo that solves Poisson's equations by using the sparse matrix. Thanks to the fast LLT factorization, this demo runs about 5x faster than the
Jacobian iteration
version on the CPU backend (on my 2019 MBP i7-9750H ).My questions are here:
pressure
.use_sp_mat
)@FantasyVR could you please help me to figure them out? Thanks in advance!