Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] GGUI 11/n: Renderer #2818

Merged
merged 2 commits into from
Aug 27, 2021
Merged

[gui] GGUI 11/n: Renderer #2818

merged 2 commits into from
Aug 27, 2021

Conversation

AmesingFlank
Copy link
Collaborator

Related issue = #2646

This is the 11th of a series of PRs that adds a GPU-based GUI to taichi.

This PR adds a renderer class, which manages a list of rendererables and renders them. The list is cached between frames and updated as needed.

@bobcao3
Copy link
Collaborator

bobcao3 commented Aug 27, 2021

FYI, I should be merging #2802 soon and the command list and submission API used in this PR will need some small changes

@AmesingFlank
Copy link
Collaborator Author

FYI, I should be merging #2802 soon and the command list and submission API used in this PR will need some small changes

Sure. I'm happy to make the necessary changes once it merges.

@bobcao3
Copy link
Collaborator

bobcao3 commented Aug 27, 2021

#2802 is merged. There is one CI fail I and @g1n0st can't reproduce yet, so you might bump into something weird. I also forced the compute queue to always be created in embedded device, I hope this is a good enough solution for now

@g1n0st g1n0st merged commit a160c60 into taichi-dev:master Aug 27, 2021
@Leonz5288 Leonz5288 mentioned this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants