Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vulkan] Fixing floating point load/store/atomics on global temps and context buffers #2796

Merged
merged 4 commits into from
Aug 26, 2021
Merged

[Vulkan] Fixing floating point load/store/atomics on global temps and context buffers #2796

merged 4 commits into from
Aug 26, 2021

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Aug 24, 2021

No description provided.

bobcao3 added 2 commits August 24, 2021 09:16
@bobcao3
enabling atomic float but fix a capability (should not set any capabi…
3d7a01b 
…lities by the existance of extensions, probing is still required)
@bobcao3
Fix floating point load/store from gtmps and context buffers & detect…
731c50d 
… shader atomic add fallback function call support (spv_variable_ptrs)
@bobcao3 bobcao3 requested review from k-ye and g1n0st August 24, 2021 17:06
@bobcao3
Copy link
Collaborator Author

bobcao3 commented Aug 24, 2021

/format

@g1n0st
Copy link
Contributor

g1n0st commented Aug 25, 2021 

=========================== short test summary info ============================
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_bit_operations.py::test_bit_shl
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_matrix.py::test_matrix_non_constant_index_numpy
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_bit_operations.py::test_bit_sar
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_mpm88.py::test_mpm88_numpy
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_reduction.py::test_reduction_different_scale
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_numpy.py::test_numpy_multiple_external_arrays
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_ssa.py::test_func_argument_dup_eval
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_torch_io.py::test_io
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_bit_operations.py::test_bit_shr
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_get_external_tensor_shape.py::test_get_external_tensor_shape_access_numpy[size0]
====== 10 failed, 480 passed, 2 skipped, 40 warnings in 889.78s (0:14:49) ======

Seems due to OpVariablePointer, we introduced some other failed tests.

@bobcao3
Copy link
Collaborator Author

bobcao3 commented Aug 25, 2021 

=========================== short test summary info ============================
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_bit_operations.py::test_bit_shl
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_matrix.py::test_matrix_non_constant_index_numpy
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_bit_operations.py::test_bit_sar
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_mpm88.py::test_mpm88_numpy
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_reduction.py::test_reduction_different_scale
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_numpy.py::test_numpy_multiple_external_arrays
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_ssa.py::test_func_argument_dup_eval
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_torch_io.py::test_io
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_bit_operations.py::test_bit_shr
FAILED ../../../../.local/lib/python3.8/site-packages/taichi/tests/test_get_external_tensor_shape.py::test_get_external_tensor_shape_access_numpy[size0]
====== 10 failed, 480 passed, 2 skipped, 40 warnings in 889.78s (0:14:49) ======

Seems due to OpVariablePointer, we introduced some other failed tests.

Some of them seems unrelated to this. It's probably other bug in the code we haven't spotted yet.

For example, the mpm88 one reported this:
[W 08/24/21 20:01:41.876 32548] [vulkan_api.cpp:taichi::lang::vulkan::`anonymous-namespace'::vk_debug_callback@50] validation layer: Validation Error: [ UNASSIGNED-CoreValidation-Shader-I nconsistentSpirv ] Object 0: handle = 0x25b7e800168, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x6bbb14 | SPIR-V module not valid: Structure id 40 decorated as Block for variable in Sto rageBuffer storage class must follow relaxed storage buffer layout rules: member 0 contains an array with stride 0 %_struct_40 = OpTypeStruct %_runtimearr_S0

@g1n0st
Copy link
Contributor

g1n0st commented Aug 25, 2021

I see... would you try to fix these in this PR?

k-ye
k-ye approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay

@g1n0st g1n0st mentioned this pull request Aug 26, 2021
Closed
@g1n0st g1n0st added the vulkan Vulkan backend label Aug 26, 2021
g1n0st
g1n0st approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@g1n0st g1n0st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for blocking this PR. XD

@g1n0st g1n0st merged commit ed389b8 into taichi-dev:master Aug 26, 2021
@Leonz5288 Leonz5288 mentioned this pull request Sep 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g1n0st g1n0st g1n0st approved these changes

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
vulkan Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bobcao3 @g1n0st @k-ye @taichi-gardener