Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Opt] [ir] Optimize offload #2673

Merged
merged 16 commits into from
Aug 21, 2021
Merged

[Opt] [ir] Optimize offload #2673

merged 16 commits into from
Aug 21, 2021

Conversation

squarefk
Copy link
Contributor

@squarefk squarefk commented Aug 13, 2021 •
edited by strongoier
Loading

Related issue = #2590

@squarefk
Copy link
Contributor Author

/format

@squarefk squarefk requested review from strongoier and k-ye August 13, 2021 08:23
@squarefk
Copy link
Contributor Author

/format

@squarefk squarefk changed the title [Opt][Ir] Optimize offload [Opt] [ir] Optimize offload Aug 13, 2021
@squarefk squarefk requested a review from xumingkuan August 13, 2021 08:50
k-ye
k-ye approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! We likely need to split visit_operand() into smaller functions

taichi/transforms/offload.cpp Outdated Show resolved Hide resolved
taichi/transforms/offload.cpp Outdated Show resolved Hide resolved
taichi/transforms/offload.cpp Show resolved Hide resolved
@squarefk
Copy link
Contributor Author

/format

@squarefk squarefk merged commit 126cf21 into taichi-dev:master Aug 21, 2021
@strongoier strongoier mentioned this pull request Aug 25, 2021
Merged
@strongoier strongoier mentioned this pull request Dec 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xumingkuan xumingkuan xumingkuan left review comments

@k-ye k-ye k-ye approved these changes

@strongoier strongoier Awaiting requested review from strongoier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@squarefk @k-ye @xumingkuan @taichi-gardener