Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] GGUI 1/n: Add necessary cuda structs/enums/functions #2645

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

AmesingFlank
Copy link
Collaborator

@AmesingFlank AmesingFlank commented Aug 9, 2021

Related Issue = #2646

This is the 1st of a series of PRs that adds a GPU-based GUI to taichi. This PR adds the necessary cuda structs, enums, and functions.

@AmesingFlank AmesingFlank requested a review from k-ye August 9, 2021 03:12
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -203,7 +203,7 @@ class Serializer {
};
};

inline std::vector<uint8> read_data_from_file(const std::string &fn) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was a typo in the original code, because uint8_t is used everywhere else. This will start to cause compile errors once we enable_language(CUDA) in cmake.

@k-ye k-ye changed the title [ui] GGUI 1/n: Add necessary cuda structs/enums/functions [gui] GGUI 1/n: Add necessary cuda structs/enums/functions Aug 9, 2021
@k-ye k-ye merged commit 67d6bba into taichi-dev:master Aug 9, 2021
@Leonz5288 Leonz5288 mentioned this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants