[ci] Fix mac release and integrate windows release into github #2641
Conversation
|
/format |
Co-authored-by: Ye Kuang <[email protected]>
| @@ -5,8 +5,8 @@ on: | |||
| types: [published] | |||
There was a problem hiding this comment.
I hope we can trigger the nightly path for each merge-to-master event, and the official build path for a release. Is it possible to achieve that?
There was a problem hiding this comment.
Yes, I'm working on this. Seems that time-based nightly release and merge-based nightly release can both work.
| export PATH=$TAICHI_REPO_DIR/taichi-llvm/bin/:$PATH | ||
| NUM_WHL=`ls dist/*.whl | wc -l` | ||
| if [ $NUM_WHL -ne 1 ]; then echo 'ERROR: created more than 1 whl.' && exit 1 ; fi | ||
| pip install dist/*.whl |
There was a problem hiding this comment.
Oh sorry for the late review, we actually want to preserve this logic :P Since we want to test a taichi installed from our built wheel (python setup.py develop is local dev mode which might slightly differ from the content inside the wheel). So we need another PR to bring this logic back.
In fact it's indeed better to unify all the CI to first build the wheel and test from there. (compared to testing in dev mode).
Related issue = #2634