Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add python docstring in misc/util.py #2599

Merged
merged 4 commits into from
Jul 30, 2021
Merged

[Doc] Add python docstring in misc/util.py #2599

merged 4 commits into from
Jul 30, 2021

Conversation

yolo2themoon
Copy link
Contributor

Related issue = #2579

@yolo2themoon
Copy link
Contributor Author

/format

@yolo2themoon yolo2themoon marked this pull request as draft July 27, 2021 13:38
@yolo2themoon yolo2themoon marked this pull request as ready for review July 27, 2021 13:38
@yolo2themoon yolo2themoon requested a review from k-ye July 27, 2021 13:44
@yolo2themoon
Copy link
Contributor Author

/format

@k-ye k-ye requested review from ljcc0930 and strongoier July 28, 2021 00:46
strongoier
strongoier approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yolo2themoon yolo2themoon marked this pull request as draft July 28, 2021 08:06
@yolo2themoon yolo2themoon marked this pull request as ready for review July 28, 2021 08:08
k-ye
k-ye reviewed Jul 29, 2021
View reviewed changes
python/taichi/misc/util.py Outdated Show resolved Hide resolved
k-ye
k-ye approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ljcc0930
ljcc0930 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@ljcc0930 ljcc0930 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k-ye k-ye merged commit 52dbb59 into taichi-dev:master Jul 30, 2021
@yolo2themoon yolo2themoon deleted the doc branch August 2, 2021 15:02
@Leonz5288 Leonz5288 mentioned this pull request Aug 3, 2021
Merged
@yolo2themoon yolo2themoon mentioned this pull request Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljcc0930 ljcc0930 ljcc0930 approved these changes

@k-ye k-ye k-ye approved these changes

@strongoier strongoier strongoier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yolo2themoon @strongoier @k-ye @ljcc0930 @taichi-gardener