Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move llvm runtime build for archs from C++ to cmake. #2524

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

ailzhang
Copy link
Contributor

When we build python packages, we used to call ti.core.compile_runtimes() to build llvm runtime for archs, but this can be conveniently done in cmake instead of invoking clang/llvm-as from C++.

This PR follows the C++ logic that we always build for host arch, and also cuda if it's available.

Our C++ code is a bit confusing in where to put the final runtime_arm64.bc (it's copied over a few times). AFAIK the hardcoded path in cmake is sufficient for now.

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2021

CLA assistant check
All committers have signed the CLA.

@ailzhang ailzhang changed the title Move llvm runtime build for archs from C++ to cmake. [Refactor]Move llvm runtime build for archs from C++ to cmake. Jul 14, 2021
@k-ye k-ye changed the title [Refactor]Move llvm runtime build for archs from C++ to cmake. [Refactor] Move llvm runtime build for archs from C++ to cmake. Jul 14, 2021
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants