Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Update links in the readme file. #2523

Merged
merged 7 commits into from
Jul 16, 2021
Merged

[doc] Update links in the readme file. #2523

merged 7 commits into from
Jul 16, 2021

Conversation

rexwangcc
Copy link
Collaborator

@rexwangcc rexwangcc commented Jul 14, 2021 •
edited
Loading

Related issue = #

Questions:

  • I'm not sure if we want to hide the link to Hub for now?
  • Is contact the right email address for security disclosures?
  • In order to fix [Cron] Sync and update documentation content docs.taichi.graphics#71, I loosened the ignore file and added the missing JSON metadata and image back to docs folder. Was there a reason to ignore JPG and JSON files repo-wide at the first place?

@rexwangcc
Copy link
Collaborator Author

/format

ailzhang
ailzhang approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the links!

@rexwangcc rexwangcc removed the request for review from k-ye July 15, 2021 00:30
@rexwangcc
Copy link
Collaborator Author

Looks like the PR is stuck due to the fact I skipped CI checks which are "required statuses before merging" 🤦

@rexwangcc rexwangcc mentioned this pull request Jul 16, 2021
Closed
@rexwangcc rexwangcc requested review from FantasyVR, k-ye and ailzhang July 16, 2021 04:03
ailzhang
ailzhang approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in frontend deployment but this looks good :P
Stamping to unblock the cron job :D

FantasyVR
FantasyVR approved these changes Jul 16, 2021
View reviewed changes
README.md Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@rexwangcc rexwangcc merged commit e44a3ec into taichi-dev:master Jul 16, 2021
@Leonz5288 Leonz5288 mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FantasyVR FantasyVR FantasyVR approved these changes

@ailzhang ailzhang ailzhang approved these changes

@yuanming-hu yuanming-hu Awaiting requested review from yuanming-hu

@k-ye k-ye Awaiting requested review from k-ye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rexwangcc @ailzhang @FantasyVR