Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Warp reduction bug fix #2519

Merged
merged 2 commits into from
Jul 13, 2021
Merged

[Bug] Warp reduction bug fix #2519

merged 2 commits into from
Jul 13, 2021

Conversation

AmesingFlank
Copy link
Collaborator

Related issue = #2518

@AmesingFlank
Copy link
Collaborator Author

AmesingFlank commented Jul 13, 2021 •
edited
Loading

The reason why this bug wasn't detected by test_reduction.py was that, even when operating on ti.f32, the test used integer values everywhere. Thus, converting to an int and then converting back does not cause any errors. I will update the tests to cover this issue.

@AmesingFlank AmesingFlank requested review from BillXu2000 and k-ye July 13, 2021 06:52
k-ye
k-ye approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the prompt fix

@k-ye k-ye merged commit 286328c into taichi-dev:master Jul 13, 2021
@Leonz5288 Leonz5288 mentioned this pull request Jul 20, 2021
Merged
@bobcao3 bobcao3 mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

@BillXu2000 BillXu2000 Awaiting requested review from BillXu2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmesingFlank @k-ye