[misc] Output "taichi_cpp_tests.exe" to the "bin" folder on Windows #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumingkuan
commented
Jul 12, 2021
| @@ -21,6 +21,11 @@ make | |||
| ./taichi_cpp_tests | |||
| ``` | |||
|
|
|||
| :::note | |||
| On Windows, `taichi_cpp_tests.exe` will be outputted into the `%TAICHI_REPO_DIR%\bin` directory, | |||
| so you can directly run it after adding the directory to `PATH` in [Setting up Taichi for development](dev_install.md#setting-up-taichi-for-development-3). | |||
There was a problem hiding this comment.
Hopefully I understand how the link works correctly -- feel free to correct me if the syntax is wrong.
Co-authored-by: Ye Kuang <[email protected]>
Merged
ailzhang
pushed a commit
that referenced
this pull request
Sep 13, 2022
Related issue = # Output all exes to build/ > This PR moves it to bin\, which is in the PATH and we can run taichi_cpp_tests everywhere. > --from #2515 (comment) IMO, we should run cpp/capi tests by running `python run_tests.py --cpp` instead of launching `taichi_cpp_tests(.exe)` manually Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2502
By default, on Windows, Taichi outputs
taichi_cpp_tests.exein somewhere likebuild\RelWithDebInfo\, which is hard to find.This PR moves it to
bin\, which is in thePATHand we can runtaichi_cpp_testseverywhere.