[ir] Add some comments to implementation of CFG optimizations and analyses #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-ye
approved these changes
Jun 29, 2021
| @@ -644,6 +642,8 @@ void ControlFlowGraph::reaching_definition_analysis(bool after_lower_access) { | |||
| to_visit.push(nodes[i].get()); | |||
| in_queue[nodes[i].get()] = true; | |||
| } | |||
|
|
|||
| // The worklist algorithm. | |||
| while (!to_visit.empty()) { | |||
There was a problem hiding this comment.
Can we implement "the worklist algo" as a separate function?
There was a problem hiding this comment.
(I thought I replied by email 7 days ago but it didn't appear here) Probably no — IIRC the reaching definition analysis and the live variable analysis use opposite (forward/backward) edges in the graph.
k-ye
approved these changes
Jul 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2193
I think the code of control-flow graph has been documented now -- feel free to tell me if any part is still not clear enough.