Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] Add set_root() for each WASM module #2429

Merged
merged 13 commits into from
Jun 24, 2021
Merged

[WASM] Add set_root() for each WASM module #2429

merged 13 commits into from
Jun 24, 2021

Conversation

squarefk
Copy link
Contributor

@squarefk squarefk commented Jun 15, 2021 •
edited by k-ye
Loading

Related issue = LAN-42

The generated WASM module now ships with a set_root() function. This function sets WASM's linear memory so that LLVMRuntime and root buffer are placed at the right place.

yuanming-hu
yuanming-hu reviewed Jun 16, 2021
View reviewed changes
taichi/backends/wasm/codegen_wasm.cpp Outdated Show resolved Hide resolved
taichi/backends/wasm/codegen_wasm.cpp Outdated Show resolved Hide resolved
k-ye
k-ye reviewed Jun 18, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits

taichi/backends/wasm/codegen_wasm.cpp Outdated Show resolved Hide resolved
taichi/backends/wasm/codegen_wasm.cpp Outdated Show resolved Hide resolved
taichi/backends/wasm/codegen_wasm.cpp Show resolved Hide resolved
@squarefk
Copy link
Contributor Author

/format

k-ye
k-ye reviewed Jun 23, 2021
View reviewed changes
taichi/backends/wasm/codegen_wasm.cpp Outdated Show resolved Hide resolved
taichi/backends/wasm/codegen_wasm.cpp Show resolved Hide resolved
taichi/backends/wasm/codegen_wasm.cpp Outdated Show resolved Hide resolved
@squarefk
Copy link
Contributor Author

/format

k-ye
k-ye approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k-ye
Copy link
Member

k-ye commented Jun 23, 2021

/format

squarefk and others added 12 commits June 24, 2021 10:22
@squarefk
[wasm] Fuse all offloaded task into single function
b42dc65
@squarefk
[wasm] Add get_root() function into each wasm module
556055c
@squarefk
[wasm] Rename get_root() into get_root_address() and add set_root()
4bbcfa4
@squarefk
[wasm] Clean up function name in wasm module
3070733
@squarefk
[wasm] Fix clean up function name for jit evaluator
5ebd70c
@squarefk
[wasm] Clean up comments and set runtime address to zero
8b0d855
@taichi-gardener @squarefk
Auto Format
5c35af7
@squarefk @k-ye
Update taichi/backends/wasm/codegen_wasm.cpp
2da36e3 
Co-authored-by: Ye Kuang <[email protected]>
@squarefk
[wasm] Update comments and make non-zero first arg valid for set_root…
9942390 
…() function
@squarefk
Update taichi/backends/wasm/codegen_wasm.cpp
447fe67
@squarefk @k-ye
Update taichi/backends/wasm/codegen_wasm.cpp
dfda1f9 
Co-authored-by: Ye Kuang <[email protected]>
@squarefk
Update taichi/backends/wasm/codegen_wasm.cpp
f3a3996
@squarefk
Copy link
Contributor Author

/format

@k-ye k-ye changed the title [WASM] Clean up codegen_wasm.cpp and add get_root() into each wasm module [WASM] Add set_root() for each WASM module Jun 24, 2021
@k-ye k-ye merged commit 030998f into taichi-dev:master Jun 24, 2021
@Leonz5288 Leonz5288 mentioned this pull request Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu left review comments

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@squarefk @k-ye @yuanming-hu @taichi-gardener