[Refactor] Add a class Callable to unify Kernel and Function #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumingkuan
added
the
large changeset
Co-authored-by: Ye Kuang <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2193
A continuation of #2306.
This PR unifies the common fields of
KernelandFunctionintoCallable, includingProgram *program;,std::unique_ptr<IRNode> ir;,std::vector<Arg> args;,std::vector<Ret> rets;.So this PR changes
Program &Kernel::programintoProgram *, which is a part of the somewhat large change set.This PR also changes
current_function_or_kernelintroduced in #2306 tocurrent_callable, unifiesCurrentFunctionGuardandCurrentKernelGuardtoCurrentCallableGuard, addsCallable::get_name(), and renamesKernelTemplateMappertoTaichiCallableTemplateMapper.BTW, I found that
program.his included in so many files that modifying it causes a long build time, similar toir.h...[Click here for the format server]