[IR] [refactor] Unify field names in load/store/atomic statements #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumingkuan
requested review from
taichi-gardener
and removed request for
taichi-gardener
Co-authored-by: Ye Kuang <[email protected]>
|
Why is @taichi-gardener not working? |
|
Well... it seems that @taichi-gardener has a different format from the CI. |
This reverts commit 64b737f
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2193
This PR renames
GlobalLoadStmt/LocalLoadStmt::ptr -> src,GlobalStoreStmt/LocalStoreStmt::ptr -> dest,GlobalStoreStmt/LocalStoreStmt::data -> val.Also renames some local variables using these fields and changes a few comments.
[Click here for the format server]