[test] [ir] Add a simple unit test for IRBuilder #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-ye
requested review from
taichi-gardener,
BillXu2000,
xumingkuan and
yuanming-hu
k-ye
commented
Mar 15, 2021
| namespace taichi { | ||
| namespace lang { | ||
|
|
||
| TEST(IRBuilder, Basic) { |
There was a problem hiding this comment.
googletest is pretty easy to learn: https://google.github.io/googletest/primer.html. By having these files unit tested, we should be able to finalize our IR/passes API, while still iterating and improving the implementations.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2196, #2193
Note that I've switched from
OBJECTtoSTATICnow. It could be too laborious to refactor the whole code base to a point where they are layered nicely. Instead, we should just create a (static) library that is unit testable by excludeingtaichi/pythonand being python-free. Most of Taichi's dependencies will be merged into this lib, including LLVM, GLEW, etc. (target_link_librariess()doesn't seem to be effective with anOBJECTlibrary)[Click here for the format server]